Re: libtool-1.5.2 fails when there's a ~ in CC

[Gary V. Vaughan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter O'Gorman wrote:
| Geoff Keating wrote:
|
| | libtool-1.5.2 fails in --mode=compile when there's a ~ in CC.
|
| This is a 1.5 branch "fix", it will be similar for HEAD. Okay to commit?

For HEAD, I've already stated that I think the world is ready for a shell
function based libtool.

Hovever, I'm not sure I want to see shell functions arrive on branch-1-5
(although the win32_lib function has been around for a long time and hasn't
elicited any bug reports to the lists), but if _you_ want to start doing
this on the branch I certainly won't object.

For the HEAD version of your patch (and branch-1-5 if you want to add shell
functions there too)  please use the function style of libtoolize.in for
consistency - leading comment with calling convention, and function purpose
description; start the name with `func_' etc.

While we are embracing the advantages of refactoring ltmain.in with functions,
why not factor out the argument quoting loops into another func too?

Anyway, stylistic issues aside, I'm okay with this patch.

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://www.oranda.demon.co.uk
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAIjbLFRMICSmD1gYRAleoAJ0YdEI4h5md+vnjBI3E7KBt5wadDQCdHtOF
JaLoVIl6rIoACT7r6gST5mw=
=5SHh
-----END PGP SIGNATURE-----