Re: libtool-1.5.x quote.test fails with solaris /bin/ksh

[Ralf Wildenhues]

Hi Alexander,

* Alexander Kurz wrote on Thu, Dec 16, 2004 at 01:49:55PM CET:
> comming back to this mail,
> 
> Ralf Wildenhues wrote:
> > * CONFIG_SHELL=/usr/local/bin/bash ./configure
> >   Does that work?
> This is a good workaround,
> libtool will be build with /usr/local/bin/bash
> as interpreter and all tests will pass.
> 
> I followed your hint to use CONFIG_SHELL=...
> and checked libtool on other systems than
> the prevously tested solaris 2.6 and 2.7 systems.
> Result: libtool-1.5.10 quote.test also fails with
> other versions/clones of ksh. I have checked so far
> * FreeBSD 4.11-Prerelease / KSH93
>  CONFIG_SHELL=/usr/local/bin/ksh93 ./configure
> * Linux / PD KSH v5.2.14 99/07/13.2
>  CONFIG_SHELL=/usr/bin/ksh ./configure
> The symptoms are the same as I described earlier:

Nope, that's not quite right:

> > * Alexander Kurz wrote on Thu, Dec 09, 2004 at 07:55:38PM CET:
> > > make check fails on tests/quote.test on
> > > \", \`, \$ }
> all other tests pass.
> 
> Maybe interesing: on Linux / PD KSH v5.2.14 99/07/13.2
> libtool-1.4.3 quote.test fails on 
> mode { compile, link, install } and quoting { \\ }

Here, the failure is only when trying to quote \\.  With the other
Shells, you had more failures.  This turns out to be a whole different
problem (actually two problems in branch-2-0 and HEAD):

If CONFIG_SHELL is set and != /bin/sh, and /bin/sh has a working builtin
echo, $ECHO will be computed wrongly.  This can be worked around by also
starting the configure script with this shell, like this:
  CONFIG_SHELL=/usr/bin/ksh /usr/bin/ksh ./configure [...]

I am still pondering how to fix this right.  But as you can see, it has
nothing to do with ksh, and everything with the initial configure setup.
(It might be interesting to know how your other Korn Shells fare when
you configure with them like above.)

The second problem (only applies to branch-2-0 and HEAD, not to
libtool-1-5) is that quote.test uses /bin/sh, no matter what
libtool uses.  Thus, libtool's value of $ECHO might not fit for
quote.test.  This should be fixed with the patch below (but that
fix is still quite ugly, I might consider a cleaner solution).

But still, what you are seeing with the SunOS ksh is a different matter,
so please answer the questions my previous private mail.

Thanks,
Ralf

        * tests/quote.test: Restart under the correct shell (the one
        $ECHO was computed for).

Index: tests/quote.test
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/quote.test,v
retrieving revision 1.14
diff -u -r1.14 quote.test
--- tests/quote.test    11 Oct 2004 15:15:00 -0000      1.14
+++ tests/quote.test    16 Dec 2004 13:55:27 -0000
@@ -26,6 +26,15 @@
 # Do the torture test.
 status=$EXIT_SUCCESS
 
+case $2 in
+  --no-reexec)
+    ;;
+  *)
+    func_get_config "SHELL" "../libtool --config"
+    exec $SHELL "$0" --no-reexec ${1+"$@"}
+    ;;
+esac
+
 func_get_config "ECHO" "../libtool --config"
 
 for mode in compile link install; do