Re: Remove double negation error messages.

[Ralf Wildenhues]

Hi Jesper,

* Jesper Louis Andersen wrote on Thu, Mar 10, 2005 at 11:56:14AM CET:
> $echo "$modename: CURRENT \`$current' is not a nonnegative integer"
> 
> (grep for it, there are a couple of places)
> 
> Should rather be something along the lines of:
> 
> $current must be a positive integer less than 100000 or zero. Double negation
> is harder to parse. Furthermore, not nonnegative is wrong because there are
> upper bounds on the size.

Thanks for reporting this.  I agree that double negation is suboptimal.
However, since the upper bound is chosen on rather pragmatic grounds
(we are pretty sure that five digits are portable), I'd rather not set
it in stone.  In doubt we might raise the limit again.

How come you saw this?  Do you actually need higher limits?

How about this patch (against HEAD, other branches similarly)?

Regards,
Ralf

        * config/ltmain.m4sh (func_mode_link): Reword double negation in
        error message.  Reported by Jesper Louis Andersen <address@hidden>.


Index: config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/config/ltmain.m4sh,v
retrieving revision 1.56
diff -u -r1.56 ltmain.m4sh
--- config/ltmain.m4sh  23 Feb 2005 03:30:30 -0000      1.56
+++ config/ltmain.m4sh  10 Mar 2005 12:31:30 -0000
@@ -4309,7 +4309,7 @@
        case $current in
        
0|[[1-9]]|[[1-9]][[0-9]]|[[1-9]][[0-9]][[0-9]]|[[1-9]][[0-9]][[0-9]][[0-9]]|[[1-9]][[0-9]][[0-9]][[0-9]][[0-9]])
 ;;
        *)
-         func_error "CURRENT \`$current' is not a nonnegative integer"
+         func_error "CURRENT \`$current' must be a small nonnegative integer."
          func_fatal_error "\`$vinfo' is not valid version information"
          ;;
        esac
@@ -4317,7 +4317,7 @@
        case $revision in
        
0|[[1-9]]|[[1-9]][[0-9]]|[[1-9]][[0-9]][[0-9]]|[[1-9]][[0-9]][[0-9]][[0-9]]|[[1-9]][[0-9]][[0-9]][[0-9]][[0-9]])
 ;;
        *)
-         func_error "REVISION \`$revision' is not a nonnegative integer"
+         func_error "REVISION \`$revision' must be a small nonnegative 
integer."
          func_fatal_error "\`$vinfo' is not valid version information"
          ;;
        esac
@@ -4325,7 +4325,7 @@
        case $age in
        
0|[[1-9]]|[[1-9]][[0-9]]|[[1-9]][[0-9]][[0-9]]|[[1-9]][[0-9]][[0-9]][[0-9]]|[[1-9]][[0-9]][[0-9]][[0-9]][[0-9]])
 ;;
        *)
-         func_error "AGE \`$age' is not a nonnegative integer"
+         func_error "AGE \`$age' must be a small nonnegative integer."
          func_fatal_error "\`$vinfo' is not valid version information"
          ;;
        esac