[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: ltmain.m4sh needs to handle spaces in paths

From: Ralf Wildenhues
Subject: FYI: ltmain.m4sh needs to handle spaces in paths
Date: Fri, 1 Jul 2005 04:23:11 +0200
User-agent: Mutt/1.5.9i

Hi Derek,

* Derek Price wrote on Thu, Jun 30, 2005 at 06:29:24PM CEST:
> There is a bug which causes libtool to exit during compilation with an
> error like, "Can't find library `'" when there are spaces in PWD.  I
> Anyhow, I later created a new bash shell and accidentally used the path
> with spaces again.  Attempting to execute the generated wrapper for my
> program brought up a second error when the PWD has spaces (the wrapper
> script can't find program since it splits PWD on spaces in the call to
> exec).  The attached patch should fix this second problem.  I have not
> dug deeply into the first.

Your patch seems fine.  It's so simple I have applied it to HEAD,
branch-2-0 and branch-1-5 right away.  Thanks!

> Not that this patch is very big, but my libtool paperwork has been
> complete for some time.  I filled it out several years back when I was
> filling out my Autoconf paperwork, despite this being my first libtool
> submission.

That's fine.  THANKS lists your paperwork exchange.  Hmm, maybe we need
to adjust that heading
| * The following people have made sufficiently significant code contributions
|   to Libtool that an exchange of legal papers with the FSF was warranted:

now that we've found out that you haven't been contributing at all.  :->


2005-07-01  Derek R. Price  <address@hidden>

        * config/ltmain.m4sh (func_mode_link) <shell wrapper>: Handle
        spaces in paths to executed programs.  Quote path in error message.

Index: config/ltmain.m4sh
RCS file: /cvsroot/libtool/libtool/config/ltmain.m4sh,v
retrieving revision 1.69
diff -u -r1.69 ltmain.m4sh
--- config/ltmain.m4sh  21 Jun 2005 14:18:24 -0000      1.69
+++ config/ltmain.m4sh  1 Jul 2005 02:15:39 -0000
@@ -6221,13 +6221,13 @@
        # Backslashes separate directories on plain windows
        *-*-mingw | *-*-os2*)
          $ECHO >> $output "\
-      exec \$progdir\\\\\$program \${1+\"address@hidden"}
+      exec \"\$progdir\\\\\$program\" \${1+\"address@hidden"}
          $ECHO >> $output "\
-      exec \$progdir/\$program \${1+\"address@hidden"}
+      exec \"\$progdir/\$program\" \${1+\"address@hidden"}
@@ -6237,7 +6237,7 @@
     # The program doesn't exist.
-    \$ECHO \"\$0: error: \$progdir/\$program does not exist\" 1>&2
+    \$ECHO \"\$0: error: \\\`\$progdir/\$program' does not exist\" 1>&2
     \$ECHO \"This script is just a wrapper for \$program.\" 1>&2
     $ECHO \"See the $PACKAGE documentation for more information.\" 1>&2
     exit 1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]