[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: tests/sh.test uses $SED without setting it

From: Derek Price
Subject: Re: tests/sh.test uses $SED without setting it
Date: Fri, 08 Jul 2005 11:20:14 -0400
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)

Hi Ralf,

Ralf Wildenhues wrote:

>Hi Derek,
>* Derek Price wrote on Thu, Jul 07, 2005 at 07:06:37PM CEST:
>>While working on some other stuff, I noticed that tests/sh.test is
>>calling $SED without it being set, though this was only causing a
>>warning message and the test passed.  I'm not sure this was the best way
>>to handle it (perhaps configure should look for sed?), but I fixed the
>>warning by having $SED default to `sed' in the attached patch.
>You omitted the patch.  I believe you are talking about branch-1-5
>Libtool, right?  How about setting SED and Xsed in tests/defs?

That would be fine, though it looks like tests/sh.test is the only test
using $SED on 1.5.  I've attached my original patch anyho in case you
want it - it just adds `: ${SED=sed}' to an early line of tests/sh.test
to set a default without overriding any environment.

>>2005-07-07  Derek R. Price  <address@hidden>
>>    * tests/sh.test (SED): Default variable contents to `sed'.


Index: tests/sh.test
RCS file: /cvsroot/libtool/libtool/tests/sh.test,v
retrieving revision
diff -u -p -r1.9.2.1 sh.test
--- tests/sh.test       21 Mar 2005 18:16:49 -0000
+++ tests/sh.test       7 Jul 2005 16:35:37 -0000
@@ -10,6 +10,8 @@ if test -z "$srcdir"; then
 . $srcdir/defs || exit 1
+: ${SED=sed}
 # Check all the "portable" shell scripts.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]