Re: workaround for virtualpc bug

[Ralf Wildenhues]

Hi Christoph,

* Christoph Egger wrote on Fri, Oct 28, 2005 at 03:00:21PM CEST:
>
> The following condition must be met to reproduce the virtualpc bug:
> 
> - VirtualPC must run in the background or in the dock
> - you must link a module and use -export-symbols
> - $output_objdir/$libname.filter must be empty

Wow.

> When the conditions are met and the error appears, then you see
> this error:
> 
> Cannot export : symbol not defined
> Creating library file: $output_objdir/$libname.dll.a
> collect2: ld returned 1 exit status
*snip*
> The patch works around the bug in virtualpc by not operating
> on an empty file.

Wouldn't this rather be a bug in sed?

> The patch has been reviewed and okey'd by Peter Ekberg (who
> originally wrote the piece of code the patch touches).

Does this simpler patch also work?
Which sed version is this, by the way?

Cheers,
Ralf

Index: libltdl/config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
retrieving revision 1.14
diff -u -r1.14 ltmain.m4sh
--- libltdl/config/ltmain.m4sh  17 Oct 2005 14:06:36 -0000      1.14
+++ libltdl/config/ltmain.m4sh  28 Oct 2005 15:47:40 -0000
@@ -5006,6 +5006,7 @@
          # global variables. join(1) would be nice here, but unfortunately
          # isn't a blessed tool.
          $opt_dry_run || $SED -e '/[[ ,]]DATA/!d;s,\(.*\)\([[ 
\,]].*\),s|^\1$|\1\2|,' < $export_symbols > $output_objdir/$libname.filter
+         test -s $output_objdir/$libname.filter && echo ': dummy' >> 
$output_objdir/$libname.filter
          delfiles="$delfiles $export_symbols $output_objdir/$libname.filter"
          export_symbols=$output_objdir/$libname.def
          $opt_dry_run || $SED -f $output_objdir/$libname.filter < 
$orig_export_symbols > $export_symbols