[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Word splitting with zsh fix

From: Ralf Wildenhues
Subject: Re: Word splitting with zsh fix
Date: Mon, 13 Feb 2006 17:52:44 +0100
User-agent: Mutt/1.5.11

[ moving to libtool-patches; sorry for the first-post moderation ]

Hi Raúl,

* DervishD wrote on Sun, Feb 12, 2006 at 11:33:15AM CET:
>  * Ralf Wildenhues <address@hidden> dixit:
> > * DervishD wrote on Sat, Feb 11, 2006 at 01:22:26PM CET:
> > >     I've spotted a problem with libtool that has to do with the word
> > > splitting that Zsh does in the expression '${1+"$@"}' (which, in
> > > turn, is a workaround to fix the "$@" expansion problem when the
> > > variable is empty in old shells). GNU autoconf has already corrected
> > > this problem, and I'm using a similar fix for libtool. The patch is
> > > gzipped and attached to this message.

> > In fact, for CVS Libtool, we just call AS_SHELL_SANITIZE to get
> > Autoconf's initialization blurb (and its fixes).
>     Oh, good idea :))


> > There is an open (unrelated) issue about that code being discussed
> > over at autoconf-patches at the moment; I'll backport it to
> > branch-1-5 as soon as that has settled.
>     OK, I'll take a look as soon as it is released :)

That seems to have settled now.  Also, I found that libtool needs to
employ the same workarounds for its shell wrappers, too (we should
eventually add a test for this, I guess, to expose this).

In the shell wrapper, we need the effect of _AS_BOURNE_COMPATIBLE, but
not AS_SHELL_SANITIZE: the executed program should run in the user's
locale.  However, _AS_BOURNE_COMPATIBLE isn't published by Autoconf.
So I'm checking in the following patches to branch-1-5 and HEAD, and
I'll write to autoconf-patches to have a public version of the macro.
When we can rely on a released Autoconf version with the published
macro, we can simplify the shell wrapper head to something like this:
|   cat >>$output <<\_LTEOF


        * libltdl/config/ltmain.m4sh (func_mode_link) <shell wrapper>: 
        Add _AS_BOURNE_COMPATIBLE code from Autoconf, to fix issues
        with zsh and other shells.
        Reported by David Gómez Espinosa <address@hidden>.

        * ltmain.in <startup, shell wrapper>: Add _AS_BOURNE_COMPATIBLE
        code from Autoconf, to fix issues with zsh and other shells.
        Reported by David Gómez Espinosa <address@hidden>.

Attachment: HEAD-bourne-compatible-wrapper.diff
Description: Text document

Attachment: branch-1-5-bourne-compatible.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]