Re: Fix chdir-long.m4 caching

[Ralf Wildenhues]

[ http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/7149/focus=5820 ]

* Eric Blake wrote on Tue, Oct 02, 2007 at 02:11:25PM CEST:
> According to Ralf Wildenhues on 10/1/2007 12:16 PM:
> > 
> > I guess branch-1-5 Libtool is affected just as well, and I wonder
> > whether, if we rename variables in Libtool, we need to provide the old
> > names for compatibility as well.
> 
> Nah.  They're cache variables; when they had the wrong name, the user
> could feasibly override the check, but the override was not saved between
> runs.  I think we're okay just upgrading to use new names, without
> worrying about priming the new names from the value of the old, nor in
> propagating the result of the new name back to the old, unless we can
> prove that the old name was in use elsewhere.

<http://sisyphus.ru/srpm/aot/spec> and
<http://sisyphus.altlinux.org/srpm/libcairo/spec>
indicate as such.  But I think in this case we're fine if we announce
the change in the NEWS file.

I'm committing the following hopefully-obvious changes to respective
Libtool branches.

Cheers,
Ralf

2007-10-11  Ralf Wildenhues  <address@hidden>

        * libltdl/m4/libtool.m4 (_LT_COMPILER_PIC)
        <lt_cv_prog_compiler_pic_works>: Renamed from
        lt_prog_compiler_pic_works.
        <lt_cv_prog_compiler_static_works>: Renamed from
        lt_prog_compiler_static_works.
        * NEWS: Update.

Index: NEWS
===================================================================
RCS file: /cvsroot/libtool/libtool/NEWS,v
retrieving revision 1.207
diff -u -r1.207 NEWS
--- NEWS        1 Sep 2007 10:55:42 -0000       1.207
+++ NEWS        11 Oct 2007 17:21:45 -0000
@@ -99,6 +99,9 @@
   - More robust parsing of mangled `.la' files inside libltdl, fixing a
     possible overrun and a crash due to memory exhaustion.
   - Fix compile command line for gcj on MinGW.
+  - Some configure variables have been renamed to fix caching:
+    lt_prog_compiler_pic_works to lt_cv_prog_compiler_pic_works
+    lt_prog_compiler_static_works to lt_cv_prog_compiler_static_works.
   - Loads of smaller bug fixes.
 
 
Index: libltdl/m4/libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/m4/libtool.m4,v
retrieving revision 1.117
diff -u -r1.117 libtool.m4
--- libltdl/m4/libtool.m4       29 Aug 2007 20:54:53 -0000      1.117
+++ libltdl/m4/libtool.m4       11 Oct 2007 17:21:45 -0000
@@ -3967,7 +3967,7 @@
 #
 if test -n "$_LT_TAGVAR(lt_prog_compiler_pic, $1)"; then
   _LT_COMPILER_OPTION([if $compiler PIC flag $_LT_TAGVAR(lt_prog_compiler_pic, 
$1) works],
-    [_LT_TAGVAR(lt_prog_compiler_pic_works, $1)],
+    [_LT_TAGVAR(lt_cv_prog_compiler_pic_works, $1)],
     [$_LT_TAGVAR(lt_prog_compiler_pic, $1)@&address@hidden([$1],[],[ 
-DPIC],[m4_if([$1],[CXX],[ -DPIC],[])])], [],
     [case $_LT_TAGVAR(lt_prog_compiler_pic, $1) in
      "" | " "*) ;;
@@ -3984,7 +3984,7 @@
 #
 wl=$_LT_TAGVAR(lt_prog_compiler_wl, $1) eval 
lt_tmp_static_flag=\"$_LT_TAGVAR(lt_prog_compiler_static, $1)\"
 _LT_LINKER_OPTION([if $compiler static flag $lt_tmp_static_flag works],
-  _LT_TAGVAR(lt_prog_compiler_static_works, $1),
+  _LT_TAGVAR(lt_cv_prog_compiler_static_works, $1),
   $lt_tmp_static_flag,
   [],
   [_LT_TAGVAR(lt_prog_compiler_static, $1)=])


2007-10-11  Ralf Wildenhues  <address@hidden>

        * libtool.m4 (AC_LIBTOOL_PROG_COMPILER_PIC)
        <lt_cv_prog_compiler_pic_works>: Renamed from
        lt_prog_compiler_pic_works.
        <lt_cv_prog_compiler_static_works>: Renamed from
        lt_prog_compiler_static_works.
        * NEWS: Update.

Index: NEWS
===================================================================
RCS file: /cvsroot/libtool/libtool/NEWS,v
retrieving revision 1.109.2.59
diff -u -r1.109.2.59 NEWS
--- NEWS        1 Sep 2007 10:56:08 -0000       1.109.2.59
+++ NEWS        11 Oct 2007 17:23:51 -0000
@@ -4,6 +4,9 @@
 * More robust parsing of mangled `.la' files inside libltdl, fixing a
   possible overrun and a crash due to memory exhaustion.
 * Fix compile command line for gcj on MinGW.
+* Some configure variables have been renamed to fix caching:
+  lt_prog_compiler_pic_works to lt_cv_prog_compiler_pic_works
+  lt_prog_compiler_static_works to lt_cv_prog_compiler_static_works.
 * Bug Fixes.
 
 New in 1.5.24: 2007-06-17; CVS version 1.5.23c, Libtool team:
Index: libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/libtool.m4,v
retrieving revision 1.314.2.187
diff -u -r1.314.2.187 libtool.m4
--- libtool.m4  16 Aug 2007 18:23:24 -0000      1.314.2.187
+++ libtool.m4  11 Oct 2007 17:23:53 -0000
@@ -5461,7 +5461,7 @@
 #
 if test -n "$_LT_AC_TAGVAR(lt_prog_compiler_pic, $1)"; then
   AC_LIBTOOL_COMPILER_OPTION([if $compiler PIC flag 
$_LT_AC_TAGVAR(lt_prog_compiler_pic, $1) works],
-    _LT_AC_TAGVAR(lt_prog_compiler_pic_works, $1),
+    _LT_AC_TAGVAR(lt_cv_prog_compiler_pic_works, $1),
     [$_LT_AC_TAGVAR(lt_prog_compiler_pic, $1)ifelse([$1],[],[ 
-DPIC],[ifelse([$1],[CXX],[ -DPIC],[])])], [],
     [case $_LT_AC_TAGVAR(lt_prog_compiler_pic, $1) in
      "" | " "*) ;;
@@ -5485,7 +5485,7 @@
 #
 wl=$_LT_AC_TAGVAR(lt_prog_compiler_wl, $1) eval 
lt_tmp_static_flag=\"$_LT_AC_TAGVAR(lt_prog_compiler_static, $1)\"
 AC_LIBTOOL_LINKER_OPTION([if $compiler static flag $lt_tmp_static_flag works],
-  _LT_AC_TAGVAR(lt_prog_compiler_static_works, $1),
+  _LT_AC_TAGVAR(lt_cv_prog_compiler_static_works, $1),
   $lt_tmp_static_flag,
   [],
   [_LT_AC_TAGVAR(lt_prog_compiler_static, $1)=])