[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
cope with dlopen(NULL) failing on AIX (was: support AIX 6.1 in config.rp
cope with dlopen(NULL) failing on AIX (was: support AIX 6.1 in config.rpath)
Sat, 12 Jan 2008 15:40:23 +0100
* Ralf Wildenhues wrote on Thu, Jan 10, 2008 at 10:20:30PM CET:
> > * Rainer Tammer wrote on Tue, Jan 08, 2008 at 05:03:30PM CET:
> > > did not find the `myfunc' function
> > > error was: Function not implemented (myfunc)
> > > did not find the `myvar' variable
> > > error was: Function not implemented (myvar)
> > > FAIL: tests/mdemo-exec.test
> branch-1-5 ltdl finds these symbols with the preopen loader.
> HEAD tries with the dlopen one, and then fails.
> I think this is due to the order in which lt_dlopen tries the loaders,
> and for some reason or other we changed that order (deliberately?) in
> HEAD over branch-1-5.
> At least with this crude hack I can get the failure to disappear.
> What I don't know yet is how to fix this right, nor why this patch would
> even be needed: glancing at the documentation, dlopen(NULL) should just
I still don't know why it doesn't "just work". But here is a somewhat
less crude hack. OK to apply? Fixing this could maybe be more nicely
be done in ltdl.c, but I would like to defer that until after 2.2, and
with this I don't see any obvious semantic downsides.
FWIW, this patch requires that LT_INIT is expanded before LTDL_INIT.
2008-01-12 Ralf Wildenhues <address@hidden>
* libltdl/m4/ltdl.m4 (_LTDL_SETUP): Define
LTDL_DLOPEN_SELF_WORKS, depending upon lt_cv_dlopen_self.
* libltdl/loaders/dlopen.c (vm_open) [!LTDL_DLOPEN_SELF_WORKS]:
Fail for dlopen(NULL), so that the preopen loader is used. This
fixes mdemo-exec.test failures on AIX where dlopen(NULL)
succeeds but dlsym resolves no symbol.
* NEWS: Update.
Report by Rainer Tammer.
RCS file: /cvsroot/libtool/libtool/NEWS,v
retrieving revision 1.213
diff -u -r1.213 NEWS
--- NEWS 11 Jan 2008 07:08:27 -0000 1.213
+++ NEWS 12 Jan 2008 14:38:45 -0000
@@ -116,6 +116,7 @@
- Some configure variables have been renamed to fix caching:
lt_prog_compiler_pic_works to lt_cv_prog_compiler_pic_works
lt_prog_compiler_static_works to lt_cv_prog_compiler_static_works.
+ - Fix 1.9b regression: lt_dlopen(NULL) works on AIX again.
- Loads of smaller bug fixes.
RCS file: /cvsroot/libtool/libtool/libltdl/loaders/dlopen.c,v
retrieving revision 1.11
diff -u -r1.11 dlopen.c
--- libltdl/loaders/dlopen.c 4 Jul 2007 23:05:05 -0000 1.11
+++ libltdl/loaders/dlopen.c 12 Jan 2008 14:38:45 -0000
@@ -1,7 +1,7 @@
/* loader-dlopen.c -- dynamic linking with dlopen/dlsym
Copyright (C) 1998, 1999, 2000, 2004, 2006,
- 2007 Free Software Foundation, Inc.
+ 2007, 2008 Free Software Foundation, Inc.
Written by Thomas Tanner, 1998
NOTE: The canonical source of this file is maintained with the
@@ -178,7 +178,14 @@
- module = dlopen (filename, module_flags);
+ /* On AIX, dlopen(NULL) succeeds but dlsym of symbols fails.
+ In this case, fail here to let the preopen loader do the job. */
+ if (!filename)
+ module = NULL;
+ module = dlopen (filename, module_flags);
RCS file: /cvsroot/libtool/libtool/libltdl/m4/ltdl.m4,v
retrieving revision 1.39
diff -u -r1.39 ltdl.m4
--- libltdl/m4/ltdl.m4 8 Jan 2008 19:39:19 -0000 1.39
+++ libltdl/m4/ltdl.m4 12 Jan 2008 14:38:46 -0000
@@ -338,6 +338,12 @@
+# lt_cv_dlopen_self gets defined by LT_SYS_DLOPEN_SELF, called by LT_INIT
+if test "$lt_cv_dlopen_self" = yes; then
+ AC_DEFINE([LTDL_DLOPEN_SELF_WORKS], ,
+ [Define if dlopen(NULL) is able to resolve symbols from the main program.])
dnl Don't require this, or it will be expanded earlier than the code
dnl that sets the variables it relies on: