bug-libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AC_LIBLTDL_CONVENIENCE


From: Ralf Wildenhues
Subject: Re: AC_LIBLTDL_CONVENIENCE
Date: Fri, 18 Apr 2008 23:51:52 +0200
User-agent: Mutt/1.5.17+20080114 (2008-01-14)

Hello Andreas,

* Andreas Schwab wrote on Wed, Apr 16, 2008 at 10:05:22AM CEST:
> 
> >  AU_DEFUN([AC_LIBLTDL_CONVENIENCE],
> > -[_LT_CONFIG_LTDL_DIR([$1])
> > +[_LT_CONFIG_LTDL_DIR(m4_ifval([$1], [$1], [libltdl]))])
> >  _LTDL_CONVENIENCE])
> 
> Too many parens.

Yep.  Also, can we have an example case for this one?

> --- libltdl/m4/ltdl.m4        1 Apr 2008 18:23:20 -0000       1.46
> +++ libltdl/m4/ltdl.m4        16 Apr 2008 08:04:41 -0000
> @@ -79,7 +79,7 @@ _$0()
>  # AC_LIBLTDL_CONVENIENCE accepted a directory argument in older libtools,
>  # now we have LT_CONFIG_LTDL_DIR:
>  AU_DEFUN([AC_LIBLTDL_CONVENIENCE],
> -[_LT_CONFIG_LTDL_DIR([$1])
> +[_LT_CONFIG_LTDL_DIR(m4_ifval([$1], [$1], [libltdl]))

This looks like to few parens (outside of m4_ifval), although I haven't
tested that and _LT_CONFIG_LTDL_DIR may require absence of quoting;
also, m4_default should be able to simplify:
  _LT_CONFIG_LTDL_DIR([m4_default([$1], [libltdl])])

Thanks,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]