bug-libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Add missing argz_* functions from glibc


From: David Lutterkort
Subject: Re: [PATCH 2/2] Add missing argz_* functions from glibc
Date: Thu, 29 May 2008 21:05:19 +0000

On Thu, 2008-05-29 at 19:43 +0200, Ralf Wildenhues wrote:
> Hi David,
> 
> * David Lutterkort wrote on Thu, May 29, 2008 at 01:06:50AM CEST:
> > 
> > +      for (p = *argz, ap = argv; *ap; ++ap, ++p)
> > +   p = __stpcpy (p, *ap);
> 
> Any reason this wasn't changed to stpcpy?

Sloppy editing combined with sloppy testing :( I managed to build my
test program on a system that had glibc, and hence didn't use gnulib's
argz. I fixed my setup, and am now getting proper link failures.

>  [ more problems with the patch ]

I'll send out a patch that addresses your and Jim's comments in a
moment.

> I'm leaning towards accepting this patch once the above issues and Jim's
> comments are addressed.  Still thinking about splitting argz.c into one
> file per function, though;

That would make automatically syncing with libc a lot easier, too.

David






reply via email to

[Prev in Thread] Current Thread [Next in Thread]