[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Add missing argz_* functions from glibc

From: David Lutterkort
Subject: Re: [PATCH 2/2] Add missing argz_* functions from glibc
Date: Tue, 03 Jun 2008 13:25:11 -0700

On Tue, 2008-06-03 at 19:12 +0200, Jim Meyering wrote:
> I've included a still-preliminary patch below, in case you'd like to test it.
> [I say preliminary because it effectively removes the C++-accommodating
> code that's in the old version and because it's totally untested.
> Adding C++ syntax is trivial, if anyone is interested. ]

I've given your patch a quick spin, and ran into the following issues:

      * __attribute_pure__ in argz.h is not defined
      * all the prototypes in argz.h are duplicated (you need to remove
        the __ prototypes, not rewrite them to ones without __)
      * dependencies of the argz module on mempcpy, stpcpy, strndup, and
        strnlen are missing
      * m4/argz.m4 doesn't check for the new functions added from libc;
        it only checks and sets HAVE_ macros for the old ones.

Apart from these, it works nicely, and I managed to build my test
program on FreeBSD and have it pass all its tests.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]