[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Add missing argz_* functions from glibc

From: David Lutterkort
Subject: Re: [PATCH 2/2] Add missing argz_* functions from glibc
Date: Tue, 03 Jun 2008 18:03:12 -0700

On Wed, 2008-06-04 at 00:57 +0200, Jim Meyering wrote:
> David Lutterkort <address@hidden> wrote:
> > 
> > I've given your patch a quick spin, and ran into the following issues:
> >
> >       * __attribute_pure__ in argz.h is not defined
> >       * all the prototypes in argz.h are duplicated (you need to remove
> >         the __ prototypes, not rewrite them to ones without __)
> >       * dependencies of the argz module on mempcpy, stpcpy, strndup, and
> >         strnlen are missing
> >       * m4/argz.m4 doesn't check for the new functions added from libc;
> >         it only checks and sets HAVE_ macros for the old ones.
> >
> > Apart from these, it works nicely, and I managed to build my test
> > program on FreeBSD and have it pass all its tests.
> Thanks for the feedback!
> I've fixed the first three things.

And with this patch, things work perfectly in my tests.

> I did notice the tests for the 7 existing symbols,
> but was reluctant to add the new ones since all functions go
> back so far.  I checked and see that argz_replace was
> added about 11 years ago, before glibc-2.0.95, so I doubt
> any useful system will have all of the existing 7 but lack
> any of the remaining functions.  So, for now at least,
> I'm inclined to leave that test as is.

Yeah, it seems silly to test for all of them; wouldn't it make sense to
check for just one of them (the last one added) ?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]