[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: libtool under msys bug
From: |
Ralf Wildenhues |
Subject: |
Re: libtool under msys bug |
Date: |
Sat, 16 Aug 2008 20:09:41 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi Sam,
Thanks for your bug report.
* Sam Thursfield wrote on Sat, Aug 16, 2008 at 07:00:34PM CEST:
> I have found this bug in 1.5 and 2.2.4. The problem is $dllsearchpatch
> has a preceding :, which confuses Windows and causes the executable
> wrapper script to not work, because it sets PATH to something Windows
> doesn't understand. If the preceeding : is removed from PATH in the
> wrapper script, it locates all of the DLL's fine.
>
> I have attached my patch which fixes the issue, although I am not sure
> of its "correctness".
The patch is pretty obviously correct; I will apply it. It would be
nice to have a test case to ensure the bug doesn't reappear. Can you
describe how to reproduce this easily (I'm not running w32 ATM)? Of
course a patch to the tests/execute-mode.at would be great too, but we
can do that. Bonus points for providing a ChangeLog entry. Mind if I
put you in THANKS?
> I also found a two year old fix here:
> https://thomas.apestaart.org/thomas/trac/browser/patches/libtool/dllsearchpath/libtool.dllsearchpath.patch
> I have not tested this and to be honest i don't understand how it
> works. My patch simply special cases an empty dllsearchpath and in
> this case, does not add a preceding colon.
It looks to me there is a plus sign missing in that patch, but it is
less portable to old shells.
> I would also like to say well done for the immense improvement in
> execution speed on win32 since libtool 2, I mean it's like ten times
> faster to build a libtool-using project now.
Well that's nice to hear!
Cheers,
Ralf
- libtool under msys bug, Sam Thursfield, 2008/08/16
- Re: libtool under msys bug,
Ralf Wildenhues <=
- Re: libtool under msys bug, Ralf Wildenhues, 2008/08/21
- Re: libtool under msys bug, Sam Thursfield, 2008/08/21
- Re: libtool under msys bug, Ralf Wildenhues, 2008/08/22
- Re: libtool under msys bug, Sam Thursfield, 2008/08/22
- Re: libtool under msys bug, Sam Thursfield, 2008/08/22
- Re: libtool under msys bug, Ralf Wildenhues, 2008/08/26