[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[2.2.6] old tests checking for allow_undefined=unsupported

From: Michael Haubenwallner
Subject: [2.2.6] old tests checking for allow_undefined=unsupported
Date: Tue, 28 Oct 2008 16:12:40 +0100


maybe I'm just puzzled, but to me it seems there are the same two
problems in each tests/cdemo-undef.test and tests/tagdemo-undef.test.

Consider this line:
        grep '^allow_undefined=.?unsupported.?$' ./libtool >/dev/null 2>&1 \

1) Shouldn't this search for "^allow_undefined_flag=.?undefined.?$"
                  instead of "^allow_undefined=.?undefined.?$"

2) The ".?" regex is not necessarily supported by non-GNU grep, it might
   not understand the '?' as expected.

Both problems lead 'tagdemo-undef.test' to FAIL while it should be
SKIPped here.

For 'cdemo-undef.test': It PASSes, and I haven't seen any undefined
symbol there. What exactly is this test for?

(patch attached, assuming ["] around the [unsupported] value)



Attachment: lt-2.2.6-undef-tests.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]