Re: libtool(20080421), mingw-cross, check-local fail for DESTDIR tests

[Ralf Wildenhues]

Hello Charles, Roumen,

* Charles Wilson wrote on Sat, Nov 08, 2008 at 05:12:18PM CET:
> Roumen Petrov wrote:
> > With attached patch now I get for libtool 2.2.4:
> > DESTDIR tests
> >  38: Simple DESTDIR install                          ok
> >  39: DESTDIR with in-package deplibs                 ok
> > 
> 
> Ping?
> http://lists.gnu.org/archive/html/bug-libtool/2008-05/msg00023.html
> 
> Seems like an obvious fix, to me

Thanks for the reminder, and the patch, and sorry for the delay.
I've pushed that one, and put Roumen in THANKS.

Cheers,
Ralf

2008-11-11  Roumen Petrov  <address@hidden>  (tiny change)

        Fix destdir tests in cross compile mode.
        * tests/destdir.at (Simple DESTDIR install)
        (DESTDIR with in-package deplibs): Use $EXEEXT throughout.
        * THANKS: Update.

diff --git a/tests/destdir.at b/tests/destdir.at
index 8ce8df3..386c728 100644
--- a/tests/destdir.at
+++ b/tests/destdir.at
@@ -56,7 +56,7 @@ $LIBTOOL --mode=compile $CC $CPPFLAGS $CFLAGS -c a.c
 $LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o liba.la a.lo -rpath $libdir
 echo 'extern int a(); int main() { return a(); }' > m.c
 $CC $CPPFLAGS $CFLAGS -c m.c
-$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o m m.$OBJEXT liba.la
+$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o m$EXEEXT m.$OBJEXT liba.la
 mkdir $DESTDIR$libdir $DESTDIR$bindir
 AT_CHECK([$LIBTOOL --mode=install cp liba.la $DESTDIR$libdir/liba.la],
         [], [ignore], [ignore])
@@ -67,7 +67,7 @@ LT_AT_MVDIR(["$DESTDIR$libdir"], ["$libdir"])
 LT_AT_MVDIR(["$DESTDIR$bindir"], ["$bindir"])
 # We ignore failure on purpose here: we may not be root.
 AT_CHECK([$LIBTOOL --mode=finish $libdir], [ignore], [ignore], [ignore])
-LT_AT_EXEC_CHECK([$bindir/m])
+LT_AT_EXEC_CHECK([$bindir/m$EXEEXT])
 
 AT_CLEANUP
 
@@ -91,7 +91,7 @@ $LIBTOOL --mode=compile $CC $CPPFLAGS $CFLAGS -c a.c
 $LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o liba.la a.lo -rpath $libdir 
liba1dep.la liba2dep.la
 echo 'extern int a(); int main() { return a(); }' > m.c
 $CC $CPPFLAGS $CFLAGS -c m.c
-$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o m m.$OBJEXT liba.la
+$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o m$EXEEXT m.$OBJEXT liba.la
 mkdir $DESTDIR$libdir $DESTDIR${libdir}2 $DESTDIR$bindir
 AT_CHECK([$LIBTOOL --mode=install cp liba1dep.la $DESTDIR$libdir/liba1dep.la],
         [], [ignore], [ignore])
@@ -124,7 +124,7 @@ for lib in a1dep a2dep a; do
   $LIBTOOL --mode=install cp lib$lib.la $DESTDIR$ldir/lib$lib.la
 done
 
-LT_AT_EXEC_CHECK([$bindir/m])
+LT_AT_EXEC_CHECK([$bindir/m$EXEEXT])
 
 # TODO: make this more portable:
 if test "$OBJDUMP" != false && ($OBJDUMP -p $bindir/m$EXEEXT) >/dev/null 2>&1; 
then