Re: testsuite.at for version 2.x Was: ... mingw-cross, check-local fail for DESTDIR tests

[Roumen Petrov]

Ralf Wildenhues wrote:
> Hello Roumen, all,
>
> apologies for the huge delay.
>
> * Roumen Petrov wrote on Sat, May 10, 2008 at 12:25:48PM CEST:
> > The libtool version before 2.x (as example 1.5x) in mingw-cross  
> > compilation environment create executables as follow:
> > - foo : wrapper shell script
> > - foo.exe : libtool wrapper executable
> > . libs/foo.exe : native(host) executable
> >
> > Since version 2.x don't create wrapper shell script in build directory  
> > make check{-local} skip any tests. The reason is code of macro  
> > LT_AT_EXEC_CHECK:
> [...]
> > The program $1 (wrapper shell scrip in 1.5x and former) don't exist,  
> > lt_status is non zero and macro code exit with status 77 (exist wrapper  
> > executable "$1"$EXEEXT).
> >
> > Also same problem in macro LT_AT_NOINST_EXEC_CHECK.
>
> Agreed.  Please try this patch.  Thanks.
>
> Others, OK to commit?
>
> Thanks,
> Ralf

Please find attached file "libtool-origin-20081118.diff.gz" (Ralf patch
+ more $EXEEXT when linking executables)
Now results from "make check-local" (only if result isn't ok):
==========================================
## -------------------------- ##
## libtool 2.2.7a test suite. ##
## -------------------------- ##

 17: preserve duplicate convenience deps             expected failure 
(duplicate_deps.at:72)
 ....
 21: F77 convenience archives                        skipped 
(convenience.at:110)
 22: FC convenience archives                         skipped 
(convenience.at:170)
 23: Java convenience archives                       skipped 
(convenience.at:267)
 ....
 25: Link order of deplibs.                          skipped 
(link-order2.at:129)
 ....
 29: static linking flags for programs               skipped 
(static.at:177)
 ....
 32: sys_lib_search_path                             skipped 
(search-path.at:57)
 ....
 35: static library contains static library          expected failure 
(archive-in-archive.at:49)
 ....
 48: enforced lib prefix                             FAILED 
(need_lib_prefix.at:184)
 ....
 68: build tree relpaths                             expected failure 
(deplibs-ident.at:68)
 ....
 74: Run tests with low max_cmd_len                  FAILED 
(cmdline_wrap.at:43)
 ....
 75: darwin fat compile                              skipped (darwin.at:42)

## ------------- ##
## Test results. ##
## ------------- ##

ERROR: 68 tests were run,
5 failed (3 expected failures).
7 tests were skipped.
==========================================

For the test 21, 22, 23 i don't have time to upgrade GCC compiler suite 
(still without Fortran and java).

Test 25 "Link order of deplibs" skipped (link-order2.at:129) - in my 
todo  for investigation.

Test 29 "static linking flags for programs" skipped (static.at:177) - 
problem is with "libtool --mode install" since real executable is in 
.libs subdirectory. No idea how to fix.

Test 32 "sys_lib_search_path" skipped (search-path.at:57) - a new skip :).
For all mingw builds the prefix is same but compiler don't list 
PREFIX/lib in sys_lib_search_path. May be if libtool is build with 
LDFLAGS=-LPREFIX/lib the new check will succeed.

Test 48 "enforced lib prefix" FAILED (need_lib_prefix.at:184) - again 
"--mode install" problem (see test 29).

Test 74 "Run tests with low max_cmd_len" FAILED (cmdline_wrap.at:43) - a 
new unexpected failure. No idea why. Before upgrade and patch was ok.


Roumen

libtool-origin-20081118.diff.gz
Description: application/gzip