[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: $ECHO change uncovered underquoting

From: Ralf Wildenhues
Subject: Re: $ECHO change uncovered underquoting
Date: Wed, 26 Nov 2008 22:43:34 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

* Paolo Bonzini wrote on Wed, Nov 26, 2008 at 08:54:29AM CET:
> > 1) Add more escaping to the input lines.  E.g.,
> >       _LT_TAGVAR(archive_cmds, $1)='$CC -o $lib $libobjs $compiler_flags 
> > `$ECHO "$deplibs" | $SED '\''s/ -lc$//'\''` -link -dll~linknames='
> > 
> > would become
> >       _LT_TAGVAR(archive_cmds, $1)='$CC -o $lib $libobjs $compiler_flags 
> > `\$ECHO "\$deplibs" | \$SED '\''s/ -lc$//'\''` -link -dll~linknames='
> If not using \$deplibs is feasible, the attached patch should fix it by
> using func_echo_all instead of $ECHO.
> It seems to me that func_echo_all is never needed in config.status.

> 2008-11-26  Paolo Bonzini  <address@hidden>
>       * HACKING: Document func_echo_all.
>       * m4/libtool.m4sh: Add it and use it throughout instead of $ECHO
>       inside eval'ed strings.

Hmm.  I suppose this is the safer approach, in the sense that it is
rather unlikely to add regressions.  I suppose that actually adding
escaping where needed (e.g., $deplibs above) would be the safer
approach in the sense of being able to deal with all kinds of input.

Luckily, both are orthogonal: we can still do the latter later.
Your patch introduces a wee bit of slowdown, but not much (all of these
commands are used at most a couple of times per invocation).

So yes, please go ahead and commit.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]