libtool generates temporary wrappers with improperly escaped LD_LIBRARY_PATH

[Brandon Philips]

Hello-

I have found that libtool generates temporary wrappers with improperly
escaped LD_LIBRARY_PATH. If the current directory path contains a colon.
For example /home/philips/test:directory/attr-2.4.43/

Steps to reproduce:

  mkdir test:directory
  cd test:directory/
  wget ftp://oss.sgi.com/projects/xfs/cmd_tars/attr_2.4.43-1.tar.gz
  tar xzvf attr_2.4.43-1.tar.gz 
  cd attr-2.4.43/
  ./configure ; make

view getfattr/getfattr and it will contain a line like:
 
   
LD_LIBRARY_PATH="/home/philips/test:directory/attr-2.4.43/libattr/.libs:$LD_LIBRARY_PATH"

Obviously this isn't going to work since colon is the path separator for
LD_LIBRARY_PATH.

getfattr/getfattr is generated with this command from the getfattr
directory:

 /usr/bin/libtool --mode=link gcc -o getfattr    getfattr.o   
../libmisc/libmisc.la ../libattr/libattr.la 

output from libtool --help:

      host-triplet:     x86_64-unknown-linux-gnu
      shell:            /bin/sh
      compiler:         gcc
      compiler flags:           -fmessage-length=0 -O2 -Wall
-D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
-fasynchronous-unwind-tables -g
      linker:           /usr/x86_64-suse-linux/bin/ld -m elf_x86_64 (gnu? yes)
      libtool:          (GNU libtool) 2.2.6
      automake:         automake (GNU automake) 1.10.1
      autoconf:         autoconf (GNU Autoconf) 2.63

Distro bug: https://bugzilla.novell.com/show_bug.cgi?id=460044

Thanks,

        Brandon