Typo in ltmain.in and ltmain.sh in libtool-1.5.26 ?

[Ian Spray]

Hi,

When using libtool as part of pkgsrc, I seem to have found a typo (vi/ 
vim insert mode ?) on the declaration of instmain that rewrites .la  
files to .lai files in some circumstances.

Unified diffs shown below:

--- ltmain.in.orig      2009-02-06 20:03:15.273276406 +0000
+++ ltmain.in   2009-02-06 20:03:46.292046949 +0000
@@ -6085,7 +6085,7 @@

        # Install the pseudo-library for information purposes.
        name=`$echo "X$file" | $Xsed -e 's%^.*/%%'`
-       instname="$dir/$name"i
+       instname="$dir/$name"
        $show "$install_prog $instname $destdir/$name"
        $run eval "$install_prog $instname $destdir/$name" || exit $?


--- ltmain.sh.orig      2009-02-06 20:03:21.861353192 +0000
+++ ltmain.sh   2009-02-06 20:03:53.272720014 +0000
@@ -6085,7 +6085,7 @@

        # Install the pseudo-library for information purposes.
        name=`$echo "X$file" | $Xsed -e 's%^.*/%%'`
-       instname="$dir/$name"i
+       instname="$dir/$name"
        $show "$install_prog $instname $destdir/$name"
        $run eval "$install_prog $instname $destdir/$name" || exit $?


--- libltdl/ltmain.sh.orig      2009-02-06 20:05:10.191801647 +0000
+++ libltdl/ltmain.sh   2009-02-06 20:05:22.978014188 +0000
@@ -6085,7 +6085,7 @@

        # Install the pseudo-library for information purposes.
        name=`$echo "X$file" | $Xsed -e 's%^.*/%%'`
-       instname="$dir/$name"i
+       instname="$dir/$name"
        $show "$install_prog $instname $destdir/$name"
        $run eval "$install_prog $instname $destdir/$name" || exit $?


I realise this isn't a full bugreport, but the way I triggered this  
was to compile pkgsrc/databases/db4 on OpenSolaris 2008.11 (which is  
beyond the scope of this list), but I can confirm that removing this  
extraneous 'i' does indeed stop mapping the .la into .lai in my build.

HTH,
--
Ian Spray
GPG Fingerprint: D170 35A3 C858 6E85 9B5B  1557 4CD5 6F6F E176 2D0A