bug-libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: LT_OUTPUT and config.status --recheck


From: Peter Rosin
Subject: Re: LT_OUTPUT and config.status --recheck
Date: Fri, 20 Mar 2009 14:05:54 +0100
User-agent: Thunderbird 2.0.0.21 (Windows/20090302)

Den 2009-03-20 12:16 skrev Peter Rosin:
Hi!

I think it is a bug that LT_OUTPUT does not create the libtool
script when you do "./config.status --recheck".

(I think the bug crept in because LT_OUTPUT shares code with the
config.status machinery, and is therefore sharing the handling of
the --no-create option which is added to the configure invocation
by config.status --recheck)

[switching list]

Turns out there was no code sharing, only copy-paste, so the
fix is easy. My initial grep of the source was faulty so I didn't
notice that right away, sorry...

I tested this on Cygwin and the config.lt test (currently
number 77) passes.

Ok to push as attached?

Cheers,
Peter
commit 301ebd4d3c2dc6c7f4d22996cf3b35e78b2ff492
Author: Peter Rosin <address@hidden>
Date:   Fri Mar 20 13:43:26 2009 +0100

    LT_OUTPUT should always create the libtool script.
    
    * libltdl/m4/libtool.m4 (LT_OUTPUT): Make LT_OUTPUT Ignore the
    --no-create configure option, and assume that the user wants
    to use an up-to-date libtool script if the LT_OUTPUT macro is
    present.
    * tests/early-libtool.at: Make sure we do not regress.
    
    Signed-off-by: Peter Rosin <address@hidden>

diff --git a/ChangeLog b/ChangeLog
index 2699a09..6585ec4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2009-03-20  Peter Rosin  <address@hidden>
+
+       LT_OUTPUT should always create the libtool script.
+       * libltdl/m4/libtool.m4 (LT_OUTPUT): Make LT_OUTPUT Ignore the
+       --no-create configure option, and assume that the user wants
+       to use an up-to-date libtool script if the LT_OUTPUT macro is
+       present.
+       * tests/early-libtool.at: Make sure we do not regress.
+
 2009-01-26  Peter Rosin  <address@hidden>
 
        Don't settle for any dumpbin/link program as name lister.
diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4
index 8fca513..477f6e3 100644
--- a/libltdl/m4/libtool.m4
+++ b/libltdl/m4/libtool.m4
@@ -677,15 +677,13 @@ chmod +x "$CONFIG_LT"
 # appending to config.log, which fails on DOS, as config.log is still kept
 # open by configure.  Here we exec the FD to /dev/null, effectively closing
 # config.log, so it can be properly (re)opened and appended to by config.lt.
-if test "$no_create" != yes; then
-  lt_cl_success=:
-  test "$silent" = yes &&
-    lt_config_lt_args="$lt_config_lt_args --quiet"
-  exec AS_MESSAGE_LOG_FD>/dev/null
-  $SHELL "$CONFIG_LT" $lt_config_lt_args || lt_cl_success=false
-  exec AS_MESSAGE_LOG_FD>>config.log
-  $lt_cl_success || AS_EXIT(1)
-fi
+lt_cl_success=:
+test "$silent" = yes &&
+  lt_config_lt_args="$lt_config_lt_args --quiet"
+exec AS_MESSAGE_LOG_FD>/dev/null
+$SHELL "$CONFIG_LT" $lt_config_lt_args || lt_cl_success=false
+exec AS_MESSAGE_LOG_FD>>config.log
+$lt_cl_success || AS_EXIT(1)
 ])# LT_OUTPUT
 
 
diff --git a/tests/early-libtool.at b/tests/early-libtool.at
index 75e26a2..7cc40b9 100644
--- a/tests/early-libtool.at
+++ b/tests/early-libtool.at
@@ -222,4 +222,8 @@ LT_AT_EXEC_CHECK([./hell], [0], [stdout])
 AT_CHECK([grep 'Welcome to GNU Hell' stdout], [], [ignore])
 AT_CHECK([grep 'This is not GNU Hello.' stdout], [], [ignore])
 
+# Make sure config.status --recheck updates the libtool script
+rm libtool
+AT_CHECK([$SHELL ./config.status --recheck],[0],[ignore],[ignore])
+
 AT_CLEANUP

reply via email to

[Prev in Thread] Current Thread [Next in Thread]