[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Useless -r argument in install-sh

From: Julien ÉLIE
Subject: Useless -r argument in install-sh
Date: Mon, 18 May 2009 23:35:46 +0200


In the latest libtool release (2.2.6a), there is an unnecessary
"-f" argument to $rmcmd here:

  rmcmd="$rmprog -f"

Indeed, the code does:

  $doit $rmcmd -f "$dst" 2>/dev/null ||
  { $doit $mvcmd -f "$dst" "$rmtmp" 2>/dev/null &&
    { $doit $rmcmd -f "$rmtmp" 2>/dev/null; :; }

Incidentally, is ":;" really useful in the last line?

There is also a direct call to "rm" here:

  rm -f "$dsttmp"

I think $doit $rmcmd might be used instead.

Have a nice day,

Julien ÉLIE

« Nul n'entre ici s'il n'est géomètre. » (Platon)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]