Re: cwrapper: possible candidate for attribute 'noreturn'

[Ralf Wildenhues]

Hello Yaakov,

* Yaakov (Cygwin/X) wrote on Fri, Sep 18, 2009 at 04:51:22AM CEST:
> Compiling libcanberra-0.17 (which adds tons of -W flags) with
> Cygwin's latest libtool-2.2.7a-14 and gcc-4.3.2-2:
> 
>   CCLD   test-canberra.exe
> ./.libs/lt-test-canberra.c: In function 'lt_fatal':
> ./.libs/lt-test-canberra.c:582: warning: function might be possible
> candidate for attribute 'noreturn' [-Wmissing-noreturn]
> 
> Chuck and I have discussed this but we would like some more input:
> 
> http://cygwin.com/ml/cygwin/2009-09/msg00435.html

Removing -Werror from $LTCC $LTCFLAGS seems like a good idea.
OTOH, adding __attribute__((noreturn)) to lt_fatal and lt_error_core
seems alright, too, but *only* if we change the latter to never
return (the other functionality is not used currently).  No sense fixing
the warning for some GCC versions and optimization flags while
introducing it for others.  And of course the attribute should be
enabled with a new-enough GCC only, that supports it.

Has Chuck sent you the copyright paper stuff?  You will need to sign
papers for any further patches.  (More info off-list if you're
interested.)

Thanks,
Ralf