bug-libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: possible bug in libtool w/ MinGW on Chinese locale


From: Ralf Wildenhues
Subject: Re: possible bug in libtool w/ MinGW on Chinese locale
Date: Wed, 17 Mar 2010 22:51:04 +0100
User-agent: Mutt/1.5.20 (2009-10-28)

* Pete Batard wrote on Sun, Mar 14, 2010 at 11:30:19PM CET:
> On 2010.03.14 07:47, Xiaofan Chen wrote:
> >On Sat, Mar 13, 2010 at 6:31 PM, Ralf Wildenhues wrote:
> >>1) Would it also be sufficient to just
> >>  LC_ALL=C; LANGUAGE=C; export LANGUAGE LC_ALL
> >
> >This is enough to solve the issue.

> >>or do you actually need LANG to be set?
> 
> From Xiaofan's tests, we probably don't need LANG to be set then.

OK.  Thanks everyone for the feedback, this is what I'll be committing
tomorrow if check passes (running ATM) and unless I hear complaints.

Cheers,
Ralf

    Unconditionally normalize LC_ALL, LANGUAGE in libtool script.
    
    * libltdl/config/ltmain.m4sh: Unconditionally set LC_ALL and
    LANGUAGE to 'C', to avoid semantic differences on MinGW under
    Chines locale.  SCO issues with e.g. LANG=C are not known to
    be relevant today any more.
    Report by Pete Batard <address@hidden> and Xiaofan Chen
    <address@hidden>.

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 8fcedc9..c7af229 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -106,9 +106,6 @@ _LTECHO_EOF'
 }
 
 # NLS nuisances: We save the old values to restore during execute mode.
-# Only set LANG and LC_ALL to C if already set.
-# These must not be set unconditionally because not all systems understand
-# e.g. LANG=C (notably SCO).
 lt_user_locale=
 lt_safe_locale=
 for lt_var in LANG LANGUAGE LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
@@ -121,6 +118,9 @@ do
          lt_safe_locale=\"$lt_var=C; \$lt_safe_locale\"
        fi"
 done
+LC_ALL=C
+LANGUAGE=C
+export LANGUAGE LC_ALL
 
 $lt_unset CDPATH
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]