bug-libtool
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libtool 2.2.11a] testsuite: 48 69 92 failed [cygwin]


From: Ralf Wildenhues
Subject: Re: [libtool 2.2.11a] testsuite: 48 69 92 failed [cygwin]
Date: Sat, 19 Jun 2010 22:38:37 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

* Charles Wilson wrote on Sat, Jun 19, 2010 at 09:26:54PM CEST:
> and ending here:
> http://lists.gnu.org/archive/html/libtool-patches/2010-06/msg00095.html
> > However, the real issue isn't the exe magic, it's the fact that the test
> > makes assumptions about what files ARE or ARE NOT in the
> > LT_MODULE_PATH_VAR.  We *hope* that there is no "last" or "first" or
> > "module" or "no_module" anywhere in there.
> ...
> > However, if this IS the desired algorithm, then the "fix" is for our
> > test to putenv (LT_MODULE_PATH_VAR, ""), right? And probably
> > LTDL_SEARCHPATH_VAR, as well. But I'm not sure we can guarantee to "null
> > out" sys_dlsearch_path at runtime; what if a file called "/usr/lib/last"
> > exists, even on linux?
> 
> Peter's patch helped to localize and identify the issue.  The attached
> fixes this regression on cygwin, but...I wonder if it is the Right Thing
> To Do.  Comments?

Seems sensible.  I think I prefer something like

  eval `$LIBTOOL --config | grep 'shlibpath_var='`
  if test -n "$shlibpath_var"; then
    CPPFLAGS="$CPPFLAGS -DLT_MODULE_PATH_VAR=\"$shlibpath_var\""
  fi

over including toplevel config.h though; and using ifdef in the code, to
cater for systems without such a variable.

Again, please leave 48 hours for comments before committing.

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]