Re: Spurious tests are run in the old testsuite.

[Peter Rosin]

Hi Ralf!

Den 2010-09-12 10:53 skrev Ralf Wildenhues:
> Hi Peter,
> 
> * Peter Rosin wrote on Fri, Sep 10, 2010 at 11:04:09AM CEST:
>> Den 2010-09-10 10:48 skrev Peter Rosin:
>>> Sigh. So, there is no way to run mdemo2-make.test and mdemo2-exec.test
>>> on systems where mdemo-dryrun.test fails.
>>
>> I managed to run them by removing the offending dependency
>> in the generated Makefile. Both of the previously skipped
>> mdemo2 tests passed and I could finally check what $NM code
>> paths they cover in the libtool script.
> 
> Your mails touch on several different but related issues.  Let's address
> this one first.  Does the patch below make things work better for you?

Nope.

$ make check-TESTS TESTSUITEFLAGS=-V TESTS="tests/mdemo-conf.test 
tests/mdemo-make.test"
make[1]: Entering directory `/home/peda/libtool/git/cygwin'
PASS: tests/mdemo-conf.test
PASS: tests/mdemo-make.test
==================
All 2 tests passed
==================
make[1]: Leaving directory `/home/peda/libtool/git/cygwin'

$ make check-TESTS TESTSUITEFLAGS=-V TESTS="tests/mdemo2-conf.test 
tests/mdemo2-make.test tests/mdemo2-exec.test"
make[1]: Entering directory `/home/peda/libtool/git/cygwin'
PASS: tests/mdemo2-conf.test
PASS: tests/mdemo-exec.test
PASS: tests/mdemo-inst.test
PASS: tests/mdemo-unst.test
PASS: tests/mdemo-dryrun.test
PASS: tests/mdemo2-make.test
PASS: tests/mdemo2-exec.test
==================
All 3 tests passed
==================
make[1]: Leaving directory `/home/peda/libtool/git/cygwin'

The test case failure has been fixed, probably by Chuck, and I managed
to get the info I needed, so there's no hurry at all to fix this. For me.

The text in README that describes how to run the old testsuite should
probably be updated to reflect the rules when this has been hashed
out.

> The problem with the patch is that it weakens up dependencies a wee bit
> too much: mdemo2-make needs tests/mdemo/libmlib.la to exist, and for
> that, either mdemo-make or mdemo-dryrun need to have run beforehand.
> Portable make unfortunately cannot express OR relationships well.
> 
> So the patch may get you in a situation where mdemo2-make will SKIP
> because prerequisites are missing.  Oh well.

I don't see how (just curious). If you have normal AND dependencies
the dependencies are as they were. I don't know anything about this
so I might be talking out my backside.

> By the way, in cases where the Makefile is really messed up, you can
> still run tests manually from the command line, as in:
>   $ cd $top_builddir
>   $ ../libtool/tests/mdemo2-make.test

Yes, I realized that I could probably do that a bit later, but by
then I already knew what I needed to know so I didn't try.

Cheers,
Peter