[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: break up functions

From: Ralf Wildenhues
Subject: Re: break up functions
Date: Sat, 2 Oct 2010 09:23:47 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

Hello Ingo,

* Ingo Krabbe wrote on Tue, Sep 28, 2010 at 08:58:49PM CEST:
> Don't we really should think about breaking up the
> func_mode_link shell function a bit.  It has over 4300 lines, and is so
> assumed unreadable by me.  Assumed you have 50 lines for a page, these
> are over 80 pages to read.  Quite hard to find the right point, where
> something goes wrong, isn't it?

I'm not going to disagree; but also, I know that it's an awful lot of
work to do this and get it right.  And at least without local variables,
it's going to be veery ugly in the end.

We have been taking some smaller steps here in the past, and I think
that is a much more viable way than a massive breakup.  But anyway I'll
be approving patches here only from contributors who then have the
resources to fix regressions in the months afterwards.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]