[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libtool 2.4 args parsing incredibly slow

From: Peter O'Gorman
Subject: Re: libtool 2.4 args parsing incredibly slow
Date: Thu, 27 Jan 2011 08:46:54 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc13 Thunderbird/3.1.7

Hi Ralf, Charles, see below.

On 01/27/2011 12:56 AM, Ralf Wildenhues wrote:

@@ -3195,6 +3195,8 @@ func_exec_program_core ()
  # launches target application with the remaining arguments.
  func_exec_program ()
+  case \${1+\"address@hidden"} in
+  *--lt*)

This can be just
   case " $* " in
   *\ --lt*)

Thanks, I will test a patch like this later today.

I like this as a first measure.  But can we also reconsider detecting
--lt-* flags only *early* in the command line?  Hmm, since we don't know
which native options accept arguments, that's always painful when
someone wants to be able to do TOOL='./tool --opt1 arg --opt2' and
somebody else appends TOOLFLAGS=--lt-foo, but maybe we can let at least
'--' delimit our search?

Well, Charles originally added this and in the email I found (and I'm not currently caffinated enough to go looking for it again, sorry), he argued for having the --lt- arguments anywhere on the command line.

Charles, $@ expansion in a loop is very slow with current bash <http://lists.gnu.org/archive/html/bug-libtool/2011-01/msg00007.html> which brings us back to the above argument.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]