[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13414: Valid DLL def file mangled by libtool
From: |
Gary V. Vaughan |
Subject: |
bug#13414: Valid DLL def file mangled by libtool |
Date: |
Sat, 19 Jan 2013 12:12:22 +0700 |
Hi Peter,
Thanks for working on this.
On 19 Jan 2013, at 05:55, Peter Rosin <address@hidden> wrote:
> On 2013-01-12 01:26, Peter Rosin wrote:
>> On 2013-01-11 12:34, Martin Doucha wrote:
>>> I'd like to report a bug in libtool 2.4 (including the latest git revision)
>>> which mangles valid DLL def files under MinGW and makes the linker barf.
>>
>> This issue has been reported before [1].
>
> So, as hinted above, I'm following up with a pair of patches that
> appear to mend this.
>
> Ok to push?
By inspection, these patches look good to me - presuming there are no
regressions, please go ahead.
One nit: your new test has a Copyright notice starting at 2007 followed by
"written in 2013". The new code doesn't look derivative of existing tests, so
I'd suggest deleting the years prior to 2013 before pushing.
> Or are the white-space changes in the first patch too intrusive?
If you would like to separate those into a separate patch then please feel
free; but I'd rather see functional progress in Libtool development than being
overly anal about changeset minutiae for potential future git archaeology at
the expense of using your Libtool hacking time more wisely :)
Cheers,
--
Gary V. Vaughan (gary AT gnu DOT org)
- bug#13414: Valid DLL def file mangled by libtool, Martin Doucha, 2013/01/11
- bug#13414: Valid DLL def file mangled by libtool, Peter Rosin, 2013/01/18
- bug#13414: [PATCH 1/2] libtool: allow tabs in $cmds variables, Peter Rosin, 2013/01/18
- bug#13414: [PATCH 2/2] libtool: factor out the dll .def file test and improve it, Peter Rosin, 2013/01/18
- bug#13414: Valid DLL def file mangled by libtool,
Gary V. Vaughan <=
- bug#13414: Valid DLL def file mangled by libtool, Peter Rosin, 2013/01/20
- bug#13414: Valid DLL def file mangled by libtool, Erik van Pienbroek, 2013/01/20
- bug#13414: Valid DLL def file mangled by libtool, Erik van Pienbroek, 2013/01/22
- bug#13414: Valid DLL def file mangled by libtool, Peter Rosin, 2013/01/22