[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#19890: [PATCH] Check for strdup NULL return value
From: |
Pavel Raiskup |
Subject: |
bug#19890: [PATCH] Check for strdup NULL return value |
Date: |
Fri, 12 Feb 2016 16:12:57 +0100 |
User-agent: |
KMail/4.14.10 (Linux/4.3.5-300.fc23.x86_64; KDE/4.14.16; x86_64; ; ) |
Thanks for the report, Tobias.
On Tuesday 17 of February 2015 22:59:55 Tobias Stoeckmann wrote:
> - if (dld_link (filename) != 0)
> + if (module == NULL)
> + {
> + LT__SETERROR (NO_MEMORY);
> + }
There is 'lt__alloc_die = lt__alloc_die_callback;' in ltdl.c (properly
setting the lasterror). Can you verify that this patch is good enough?
| libltdl: handle ENOMEM sooner
|
| * libltdl/loaders/dld_link.c (vm_open): Do not even try dld_link()
| in case of ENOMEM.
|
| diff --git a/libltdl/loaders/dld_link.c b/libltdl/loaders/dld_link.c
| index a73880f..0edf0df 100644
| --- a/libltdl/loaders/dld_link.c
| +++ b/libltdl/loaders/dld_link.c
| @@ -112,7 +112,7 @@ vm_open (lt_user_data loader_data LT__UNUSED, const char
*filename,
| {
| lt_module module = lt__strdup (filename);
|
| - if (dld_link (filename) != 0)
| + if (module && dld_link (filename) != 0)
| {
| LT__SETERROR (CANNOT_OPEN);
| FREE (module);
Pavel
- bug#19890: [PATCH] Check for strdup NULL return value,
Pavel Raiskup <=