From:
Bruno Haible <bruno@clisp.org>
Date: Saturday, 2021-08-07 at 17:06
To: Nicole Mazzuca <mazzucan@outlook.com>
Cc: bug-libunistring@gnu.org <bug-libunistring@gnu.org>
Subject: Re: [bug-libunistring] Build Error
Thanks a lot for the analysis of this problem! I had just stumbled across it,
and did not have time to look into it.
> And the reason that automake 1.16.4 broke this is this change:
>
> ```patch
> --- a/m4/init.m4
> +++ b/m4/init.m4
> @@ -65,5 +65,5 @@
> dnl Diagnose old-style AC_INIT with new-style AM_AUTOMAKE_INIT.
> m4_if(
> - m4_ifdef([AC_PACKAGE_NAME], [ok]):m4_ifdef([AC_PACKAGE_VERSION], [ok]),
> + m4_ifset([AC_PACKAGE_NAME], [ok]):m4_ifset([AC_PACKAGE_VERSION], [ok]),
> [ok:ok],,
> [m4_fatal([AC_INIT should be called with package and version arguments])])dnl
> ```
Indeed!!
> One way to solve this is:
>
> ```patch
> --- a/m4/init-package-version.m4
> +++ b/m4/init-package-version.m4
> @@ -82,9 +82,9 @@
> [AC_SUBST([PACKAGE], [$1])
> AC_SUBST([VERSION], [$2])
> ])
> m4_define([AM_INIT_AUTOMAKE],
> m4_defn([gl_RPL_INIT_AUTOMAKE]))
> ])
> -m4_define([gl_INIT_DUMMY], [])
> +m4_define([gl_INIT_DUMMY], [dummy])
> AC_DEFUN([gl_RPL_INIT_AUTOMAKE], [
> m4_ifval([$2],
> ```
Yes, this would solve it. Thanks! I prefer the patch
https://git.savannah.gnu.org/gitweb/?p=libunistring.git;a=commitdiff;h=15e4365267e316f15222b8bf9f0a7cd0db231e9c
(just for esthetic reasons).
Bruno