Re: Building 2.8.1 segfaults if ~/.rh-fontconfig does not exist.

[Quentin Spencer]

Han-Wen Nienhuys <hanwen <at> lilypond.org> writes:

> 
> Quentin Spencer schreef:
> > I'm trying to package 2.8.1 for Fedora Extras. I am getting the following
> > error during a build:
> > 
> > 
> > Initializing FontConfig...
> > Rebuilding FontConfig cache /home/qspencer/.rh-fontconfig/.fonts.cache-2.
> > this may take a while...
> > adding font directory:
> > 
/home/qspencer/rpm/BUILD/lilypond-2.8.1/out/share/lilypond/current/fonts/otf/
> > adding font directory:
> > 
/home/qspencer/rpm/BUILD/lilypond-2.8.1/out/share/lilypond/current/fonts/type1/
> > Building font database.
> > /bin/sh: line 1: 21855 Segmentation fault     
> > /home/qspencer/rpm/BUILD/lilypond-2.8.1/lily/out/lilypond --verbose
> > /home/qspencer/rpm/BUILD/lilypond-2.8.1/ly/generate-documentation
> > make[2]: *** [out/lilypond-internals.texi] Error 139
> > make[2]: Leaving directory
> > `/home/qspencer/rpm/BUILD/lilypond-2.8.1/Documentation/user'
> > make[1]: *** [all] Error 2
> > make[1]: Leaving directory
> > `/home/qspencer/rpm/BUILD/lilypond-2.8.1/Documentation'
> > make: *** [all] Error 2
> > 
> > 
> > After looking at lily/fontconfig.cc to see what was happening, it appears
> > that it is trying to create and write to the file
> > ~/.rh-fontconfig/.fonts.cache-2,
> > whether or not ~/.rh-fontconfig exists. If it doesn't exist, it crashes; if
> > it does exist, everything is fine and the build finishes. In the Fedora
> > Extras build system, the build is exectuted in a temporary build directory
> > and the font cache directory will never exist.
> > 
> 
> thanks, should be fixed now.


Thanks for fixing this. I just noticed you have a 2.8.3 release on the web site.
I tried diffing 2.8.3 against 2.8.2 and noticed that the ChangeLog contained the
following entry:

       * lily/font-config.cc (init_fontconfig): only close non-NULL file.

However, font-config.cc is unchanged, so you apparently didn't apply the change
to the 2.8.x branch.

Quentin