[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Partial ties not performed

From: Han-Wen Nienhuys
Subject: Re: Partial ties not performed
Date: Mon, 04 Sep 2006 13:48:57 +0200
User-agent: Thunderbird (X11/20060803)

Michael Welsh Duggan wrote:
Partial ties are not picked up by the tie engraver.  The included
patch fixes the problem, but I have no idea whether it fits into the
spirit of the code.

looks good.

a few nits:

 - Changelog entry missing
+      if (an->tie_event_) {
+        now_tied_heads_.push_back (inf);
+      } else {
+        now_heads_.push_back (inf);
+      }

don't use braces for statements.

-  Audio_note (Pitch p, Moment m, int transposing_i = 0);
+  Audio_note (Pitch p, Moment m, bool tie_event, int transposing_i = 0);

While you're at it, can you see whether you could remove the transposing_i argument? We've stopped using default args a long time ago.

Can you fix and resend ?



Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen

LilyPond Software Design
 -- Code for Music Notation

reply via email to

[Prev in Thread] Current Thread [Next in Thread]