Re: pitch_squash_engraver broken in 2.11.22

[Mats Bengtsson]

The engraver certainly works correctly, since RhythmicStaff contexts work
correctly. On the other hand, I looked back into earlier versions of the 
manual
as far back as version 2.2 and I doubt that the example has ever worked.
The problem is not the engraver itself, but that the \improvisationOn/Off
commands only set the squashedPosition property in the Voice context,
whereas the example adds the engraver one step higher up in the context
hierarchy, to the Staff context. Therefore, the following version of the
example works as it should:

\new Voice \with {
 \consists Pitch_squash_engraver
} \transpose c c' {
 e8 e g a a16(bes)(a8) g \improvisationOn
 e8
 ~e2~e8 f4 fis8
 ~fis2 \improvisationOff a16(bes) a8 g e
}


An alternative would be to redefine the \improvisationOn/Off commands
to set the property in the Staff context, but then they wouldn't support
situations where you have multiple voices in the same stave and want to
turn the improvisation on/off individually for the different voices. 
Therefore,
I will update the example in the manual according to the example given 
above.

   /Mats

Bruce McIntyre wrote:
> > I'm not top posting.
> >     
>
> %% pitch_squash_engraver is broken in 2.11.22
> %% consequently \improvisationOn is broken
>
> %% this is example from
> %%http://lilypond.org/doc/v2.11/Documentation/user/lilypond/Improvisation#Improvisation
> %% consider adding this to regression test?
>
> \new Staff \with {
>   \consists Pitch_squash_engraver
> } \transpose c c' {
>   e8 e g a a16(bes)(a8) g \improvisationOn
>   e8
>   ~e2~e8 f4 fis8
>   ~fis2 \improvisationOff a16(bes) a8 g e
> }
>
>
>
> _______________________________________________
> bug-lilypond mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/bug-lilypond
>   

--
=============================================
        Mats Bengtsson
        Signal Processing
        Signals, Sensors and Systems
        Royal Institute of Technology
        SE-100 44  STOCKHOLM
        Sweden
        Phone: (+46) 8 790 8463                         
       Fax:   (+46) 8 790 7260
        Email: address@hidden
        WWW: http://www.s3.kth.se/~mabe
=============================================