bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 381 in lilypond: input/regression/accidental-tie.ly


From: Han-Wen Nienhuys
Subject: Re: Issue 381 in lilypond: input/regression/accidental-tie.ly
Date: Thu, 5 Jul 2007 13:02:22 -0300

2007/7/5, Joe Neeman <address@hidden>:
This seems to have been caused by commit b80bb48c. Before line breaking is
done, tie->original () will always return 0, so the accidental will always
suicide. I've reverted this in the jneeman branch but I don't want to merge
it until I work out why the patch was originally made. The only things I can
think of were that the accidental was interfering with spacing or with slur
positioning.

The spacing code deals with this situation explicitly -- it looks out for
accidentals and leaves them out of skylines that they shouldn't be in.

I think the proper solution is to make sure that print() isnĀ“t called
before line breaking, ie. make a common function create_stencil() that
does the lookup but does not perform suicide, use that to do any
stencil lookups before line breaking (eg. to compute width/height).
Of course, you may look into why print() is called before line
breaking.

In general all before/after-line-breaking callbacks are not
data-driven, so they should disappear.


--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]