Issue 546 in lilypond: Incorrect merging when a same note has different accidentals

[codesite-noreply]

Issue 546: Incorrect merging when a same note has different accidentals
http://code.google.com/p/lilypond/issues/detail?id=546

Comment #12 by joeneeman:
Hi Erlend, there are at least 2 bugs in your implementation 
(admittedly, the music
that would trigger them is a little strange...): First, if you have alternating
accidentals of different types then each one will get its own ape. 
Also, notes in
different octaves with different alterations will be placed in 
different apes
(actually, I'm not sure if this is a bug but it is a departure from the current
behaviour). And on a style note, 
Accidental_placement::calc_positioning_done (which
was too long to begin with) is now almost 250 lines long!

Anyway, I have a set of three patches that breaks up
Accidental_placement::calc_positioning and fixes this bug (at least the 
collision
part of it). (I don't mean to "compete" to solve this bug; I actually 
wrote the
patches before I realised that you wrote some too.) I hope they apply 
cleanly -- I
haven't been able to pull for a week or so.

Attachments:
        bugs.ly  112 bytes
        test.preview.png  2.1 KB
        0001-Start-to-break-Accidental_placement-calc_positionin.patch  7.5 KB
        0002-Refactor-accidental-placement.patch  7.3 KB
        0003-Fix-546.patch  5.9 KB



--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings