Re: hyphens not working in 2.13

[Francisco Vila]

2009/6/28 Francisco Vila <address@hidden>:

> 2009/6/28  <address@hidden>:
>> I use it without even putting slurs and the same bug appears just using
>> for instance this :
>>
>> \relative c'{
>>  c d e f f e e e  }
>> \addlyrics
>>  { Ky -- _ _ ri __ _ _ _  e }
>>


> The bug could have been caused by this but I'm going to look at it in depth.
>
> commit 7531ea6b3bb254f4d82aabde347a91671533b45a
> Author: Chris Snyder <address@hidden>
> Date:   Mon Mar 16 16:51:26 2009 -0700
>
>    Fix lyric extenders to end properly when there are notes but no more 
> lyrics.
>
>    The previous extender code only ends extenders when the next
>    lyric is encountered. This can lead to issues when there are
> additional notes,
>    but no more lyrics. This patch adds a check to see if a
>    melisma is ending, completetizing the extender if appropriate.

I confirm that this is the first commit that shows the new behaviour.

The regression test and the underlying logic of the fix attempt are
wrong IMHO , because they do not test the existence of additional
lyrics. If the "no more lyrics" case is problematic, this shouldn't
break the case in that there are actually additional lyrics. Anyway,
now the extender is prematurely stopped with or without slurred notes
or additional lyrics, as the last Karim's example shows.

-- 
Francisco Vila. Badajoz (Spain)
www.paconet.org