[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: hyphens not working in 2.13

From: Graham Percival
Subject: Re: hyphens not working in 2.13
Date: Tue, 30 Jun 2009 23:48:22 -0700
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Jun 29, 2009 at 09:15:31PM -0400, Chris Snyder wrote:
> > The regression test and the underlying logic of the fix attempt are
> > wrong IMHO , because they do not test the existence of additional
> > lyrics. If the "no more lyrics" case is problematic, this shouldn't
> > break the case in that there are actually additional lyrics. Anyway,
> > now the extender is prematurely stopped with or without slurred notes
> > or additional lyrics, as the last Karim's example shows.
> Sorry for the regression. It's possible that there actually are
> regression tests that show it, but the delta-calculating logic in the
> tests doesn't deal well with the thin extender lines (which I noted when
> I submitted the patch).
> It will be difficult for me to write a patch to fix this right now, as
> I'm limited to a crappy hotel Internet connection for the next couple of
> days, but I'll look into a fix if no-one beats me to it. I think the
> proper solution would be to add a check for the single-underscore case,
> and avoid completizing the extender if one is found.

I've lost track of this issue.  Was it added to the google
tracker, and if not, does it need to be, and if so, could somebody
write the appropriate text or minimal example?

Actually, better idea.  If we need an issue, Francisco can add it.

- Graham

reply via email to

[Prev in Thread] Current Thread [Next in Thread]