bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Issue 947 in lilypond: Build failure on OS X on std-vector.hh


From: lilypond
Subject: Issue 947 in lilypond: Build failure on OS X on std-vector.hh
Date: Mon, 21 Dec 2009 12:06:16 +0000

Status: Accepted
Owner: nicolas.sceaux
Labels: OpSys-OSX Priority-Low

New issue 947 by nicolas.sceaux: Build failure on OS X on std-vector.hh
http://code.google.com/p/lilypond/issues/detail?id=947

Harmath Dénes reports:

"""
When running make all on OS X 10.6.2, I get the following C++ compilation error:

In file included from /usr/include/c++/4.2.1/vector:70,
               from ./include/std-vector.hh:78,
               from ./include/file-name.hh:23,
               from file-name.cc:21:
/usr/include/c++/4.2.1/bits/stl_vector.h:162: error: template class without a
name
/usr/include/c++/4.2.1/bits/stl_vector.h:170: error: expected unqualified-id
before '<' token

...and things go downhill from there, flooding the screen with C++ syntax
errors.

According to the discussion in
http://www.mail-archive.com/address@hidden/msg29280.html,
there is a workaround, issuing the command

perl -pi -e 's|__vector|lily_vector|g' flower/include/std-vector.hh

solves the problem.
If it compiles well on other platforms with it, LilyPond should contain the
patched version of std-vector.hh.
"""

A similar patch have been proposed by Dan Eble in september 2008, and Han-Wen answered:
"""
I'm a little bit concerned that this might break on other platforms.
Is anyone familiar with the finesses of gcc's STL on various
platforms? Ideally, the

  !HAVE_STL_DATA_METHOD

should probably die, but I don't know for which GCC versions we are
catering exactly.
"""

I have committed the following patch:
<http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=6b78efc2ea0cb064850c264ff225d9930353a178>
but I was probably too hasty, considering Han-Wen concerns.

If the patch actually breaks building on other platforms, or is considered a bad idea, then it shall be reverted.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

reply via email to

[Prev in Thread] Current Thread [Next in Thread]