bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: T405 - Respect user setting bracket-visibility property. (issue1940


From: ian
Subject: Re: T405 - Respect user setting bracket-visibility property. (issue194095)
Date: Sun, 21 Feb 2010 12:34:25 +0000

Reviewers: Neil Puttock,

Message:
Hi Neil,
I've fixed the comment.  Please push this patch (I've rebased it to
branch from latest origin/master).

Cheers,

Ian


http://codereview.appspot.com/194095/diff/1/2
File lily/tuplet-bracket.cc (right):

http://codereview.appspot.com/194095/diff/1/2#newcode286
lily/tuplet-bracket.cc:286: SCM bracket_vis_prop = me->get_property
("bracket-visibility"); // The type of this prop is sucky.
On 2010/02/20 17:27:56, Neil Puttock wrote:
Unless you're going to fix this, you shouldn't remove the FIXME

Done.
Restored the block comment and the FIXME:

Description:
T405 - Respect user setting bracket-visibility property.

Please review this at http://codereview.appspot.com/194095/show

Affected files:
  M lily/tuplet-bracket.cc






reply via email to

[Prev in Thread] Current Thread [Next in Thread]