[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 989 in lilypond: ensure that no information is only in the reg
From: |
lilypond |
Subject: |
Re: Issue 989 in lilypond: ensure that no information is only in the regtests |
Date: |
Mon, 22 Mar 2010 20:50:26 +0000 |
Comment #5 on issue 989 by percival.music.ca: ensure that no information is
only in the regtests
http://code.google.com/p/lilypond/issues/detail?id=989
Unfortunately, most of the regtests that Valentin picked out don't have
anything to
do with the NR, so it's not your concern. The first one that looks like
one for you is:
------
bend-after.ly
-> \bendAfter supports non-integer arguments,
this is undocumented AFAICS. Snippet?
I'd mention it in the docs.
---------
Here's how you'd solve it:
1. find \bendAfter in the docs.
2. add a non-integer argument (i.e. 2.5) to the example. (I mean, add
another bar
with a \bendAfter 2.5 and maybe another \bendAfter -2.5).
3. check that the example looks decent, shows what it's meant to show,
etc. Maybe
2.5 is a bad number -- should it be higher or lower? (I'm totally guessing
here)
4. consider adding the sentence "The number of staff spaces can be a
non-integer
number", although if it's clear from the example (which it should be), then
don't add
such a sentence.
5. send me a patch. Follow our guidelines for that. :)
In general, if somebody says "snippet" or "LSR" after one of the regtests,
skip over
it immediately because it's not your concern.
chord-skips.ly looks like the next contender for the NR. Find the place
where we
discuss chords, find a good place to discuss articulations inside the
chord, and
modify an example (or add a whole new example) accordingly. (in this case,
you
probably want to add one 1-2 sentence paragraph, followed by a new
@lilypond).
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings