bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: Lyrics break estimation of vertical spacing


From: Boris Shingarov
Subject: Re: PATCH: Lyrics break estimation of vertical spacing
Date: Mon, 12 Apr 2010 13:46:55 -0400
User-agent: Webmail 5.0

Ok, this patch is ready for code review:
http://codereview.appspot.com/872044

On Thu, 08 Apr 2010 23:47:15 -0700, Joe Neeman  wrote:
On Mon, 2010-04-05 at 03:00 -0400, Boris Shingarov wrote:
 > > > >    Grob *alignment = get_vertical_alignment (); //TODO check for null
 > > > please check for null
 > >
 > > But what do we do if it's null?
 >
 > Maybe print a programming_error and return an empty extent? It doesn't
> particularly matter what you do, just don't crash. >
 > Joe
 >
 >
 >






reply via email to

[Prev in Thread] Current Thread [Next in Thread]