Re: Issue 943 in lilypond: input/regression/slur-broken-trend.ly broken

[lilypond]

Comment #22 on issue 943 by pnorcks: input/regression/slur-broken-trend.ly  
broken
http://code.google.com/p/lilypond/issues/detail?id=943

Further information:

The function call order is different (as I suspected) with current git  
compared to
that after applying Neil's patch (or reverting Joe's commit).  Details are  
below so
that I don't lose them.

Currently, the post-line-break slur depends on the the pre-line-break slur  
setting
its direction to the correct value.  But since the function call sequence  
changed,
the post-line-break slur shape is already calculated before the direction  
is set, so
setting the direction has no effect.

***

Slur1: (before line break)
Slur2: (after line break)

Current git
===========
Function order:
- calc_control_points (Slur2) -> dir_ == DOWN
- set_next_direction (Slur2) -> returns immediately
- height (Slur1)
- calc_control_points (Slur1)
- set_next_direction (Slur1) -> sets direction of Slur2 to UP
- height (Slur2)

With Neil's patch
=================
Function order:
- height (Slur1)
- calc_control_points (Slur1)
- set_next_direction (Slur1) -> sets direction of Slur2 to UP
- height (Slur2)
- calc_control_points (Slur2) -> dir_ == UP
- set_next_direction (Slur2) -> returns immediately

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings