Re: Problem with 2.13.30?

[Reinhold Kainhofer]

Am Donnerstag, 19. August 2010, 09:43:11 schrieb Phil Holmes:
> "Trevor Daniels" <address@hidden> wrote in message
> news:address@hidden
> 
> > Eluze wrote Sunday, August 15, 2010 10:20 AM
> > 
> >> Trevor Daniels wrote:
> >>> The mingw binary of 2.13.30 gives the following error
> >>> under Vista on my system:
[...]
> >>>   File "out/book_base.py", line 4, in ?
> >>>   File "out/book_snippets.py", line 9, in ?
> >>>   File "c:\Program Files\LilyPond\usr\lib\python2.4\subprocess.py",
> >>> line 352, in ?
> >>>     import msvcrt
> >>> 
> >>> ImportError: No module named msvcrt
> >>> Lilypond-book returned code 1
[...]
> > Reinhold's refactoring of lilypond-book modules was
> > first included in the 2.13.24 release, so this looks
> > a more likely cause.  He made a series of changes
> > terminating in commit 7d4265883794cec4ad0e7312f0787d0565fe757f
> > on 11 Jun 2010.

The filter_pipe function used os.popen3, which according to the python 
documentation has been deprecated since python 2.6: 
http://docs.python.org/library/os.html

The suggested replacement is subprocess.Popen, see also 
http://docs.python.org/release/2.4/lib/node238.html and  
http://docs.python.org/release/2.4/lib/module-subprocess.html. In windows, the 
subprocess module needs the msvcrt python module, which is part of the python 
standard lib since 2.4: http://docs.python.org/release/2.4/lib/module-
msvcrt.html

Unfortunately, it seems that in GUB, python is not built with that python 
module, so of course the subprocess module refuses to laod.

I have now reverted the filter_pipe function to use the deprecated os.popen3 
again. However, if we ever resolve the subprocess/msvcrt issue in Windows, we 
should replace all those deprecated functions by the proper "new" 
functions....

Cheers,
Reinhold
-- 
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org