[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: DynamicTextSpanner is not fully contained in parent spanner
From: |
Neil Puttock |
Subject: |
Re: DynamicTextSpanner is not fully contained in parent spanner |
Date: |
Sun, 12 Sep 2010 20:55:59 +0100 |
On 11 September 2010 06:47, Jay Anderson <address@hidden> wrote:
> This is definitely a hack, but it works for me:
>
> diff --git a/lily/spanner.cc b/lily/spanner.cc
> index 32e0d21..827f5d6 100644
> --- a/lily/spanner.cc
> +++ b/lily/spanner.cc
> @@ -112,6 +112,8 @@ Spanner::do_break_processing ()
>
> bool ok = parent_rank_slice.contains
> (bounds[LEFT]->get_column ()->get_rank ());
> ok = ok && parent_rank_slice.contains
> (bounds[RIGHT]->get_column ()->get_rank ());
> +
> + ok = ok || ly_symbol2scm("none") == get_property ("style");
>
> if (!ok)
> {
>
I initially thought the same, but there are two problems with this approach:
-) It ignores dynamic spanners which have been ended early due to
\breakDynamicSpan.
-) Not all spanners support the 'style property, so there would need
to be an interface check first (otherwise we'd get lots of warnings in
regression tests).
> I haven't spent the time to understand how things work yet, but this
> at least gets me past this problem for now.
You can still use the old method for hiding lines:
\override DynamicTextSpanner #'dash-period = #-1
Cheers,
Neil