bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1336 in lilypond: skipTypesetting segfaults when set during a


From: lilypond
Subject: Re: Issue 1336 in lilypond: skipTypesetting segfaults when set during a skipBars-induced MultiMeasureRest spanner
Date: Sat, 11 Dec 2010 14:48:19 +0000


Comment #30 on issue 1336 by percival.music.ca: skipTypesetting segfaults when set during a skipBars-induced MultiMeasureRest spanner
http://code.google.com/p/lilypond/issues/detail?id=1336

As long as your patch passes the regtests, I'd so go for it.

I just tried compiling the regtests with your patch + the one below, and nothing crashed. I didn't do an actual regtest *comparison*, so it's possible that my patch makes something stop working. If any unskilled programmer has some time, it would be great if they could do a regtest comparison between current git master and master+Neil's patch + this patch.


diff --git a/lily/simple-spacer.cc b/lily/simple-spacer.cc
index 9cdf664..e320c30 100644
--- a/lily/simple-spacer.cc
+++ b/lily/simple-spacer.cc
@@ -393,6 +393,11 @@ vector<Real>
 get_line_forces (vector<Grob*> const &columns,
                 Real line_len, Real indent, bool ragged)
 {
+  if (columns.size() < 2) {
+    printf("whoops, time to bail\n");
+    printf("Not enough music in score.\n");
+    exit(0);
+  }
   vector<vsize> breaks;
   vector<Real> force;
   vector<Grob*> non_loose;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]