Re: Fw: collision between MMR and key signature

[Keith OHara]

On Tue, 11 Jan 2011 09:39:23 -0800, Neil Puttock <address@hidden> wrote:
> On 10 January 2011 20:29, Keith OHara <address@hidden> wrote:
>
> > It looks like all other items that needed it got an extra-spacing-height.
> >  I'm unclear on the zero-height-skyline concept, though,
> > and worry that typically end-of-line items like KeyCancellation might need
> > an extra-spacing-height for some reason I don't see.
>
> I don't think it's necessary since the cancellation usually follows a
> barline (and precedes the end-of-line key signature reminder).  The
> only situation where a collision would occur is highly artificial (and
> ambiguous):

Neil,
Setting extra-spacing-height for KeySigs (or KeyCancels, or both) gives a clean 
make check.
I checked that issue 1120 remains fixed; and experimented a bit looking for 
other trouble, found none.

What do you think about pushing the patch for KeySigs only to master?  Then if 
this bug gets classified critical Graham can just cherry pick the commit, and 
leave it on master otherwise, if I understand the process correctly.

The reason I missed this bug myself was that I had a \grace s8 after every key 
change, just in case I needed something to align a \tempo to.  Thanks to the 
break-align fix, when 2.14 is out I won't have to do that anymore.
--
Keith

0001-Followup-to-fix-for-issue-1120.patch
Description: Binary data