Re: horizontal spacing regression

[Joe Neeman]

On Fri, Jan 14, 2011 at 11:57 AM, Carl Sorensen <address@hidden> wrote:

> On 1/13/11 10:25 PM, "Keith OHara" <address@hidden> wrote:
>
> > -------- Original Message --------
> >> From: "Carl Sorensen" <address@hidden>
> >> Sent: Thursday, January 13, 2011 4:23 PM
> >> To: "Keith OHara" <address@hidden>, "address@hidden"
> > <address@hidden>
> >> Subject: Re: horizontal spacing regression
> >>
> >> Here's a workaround.  I haven't done a regtest, so I don't know if this
> > is
> >> something we want to add to the definition in scm/define-grobs.scm.
> >>
> >> [...] Accidental #'extra-spacing-height = #'(-0.5 . 0.5)
> >
> > The regression output that changed is:
> >
> > spacing-horizontal-skyline.ly "accidentals may be folded under preceding
> > notes."
> > Two accidentals remain tucked, but this case does not:
> >   ceses!4...  feses! r16
>
> So it seems that making this change affects a desired behavior (as
> described
> in a regtest).  If, in your opinion, the output is better overall with the
> new behavior, we should probably do the following:
>
> 1) Have a discussion on -devel, with images shown before and after
> 2) Change something about the description of spacing-horizontal-skyline.ly
> to indicate under which conditions tucking is *not* allowed.
>
> Otherwise, we'll need to figure out some other method of approaching this.
>

I think you'll find that the regression was caused by ee0488, in which case
the extra-spacing-height override is exactly the thing to do if you want to
restore the old behaviour. It's really just a question of how much padding
to add; I don't think it's worth a long discussion.

Cheers,
Joe