Re: Issue 1472 in lilypond: Collision between MMR and key signature

[lilypond]

Comment #8 on issue 1472 by address@hidden: Collision between MMR and key  
signature
http://code.google.com/p/lilypond/issues/detail?id=1472

Here is the state of things:

1/6
Bug is first reported on the bug list.

1/7
Neil reports adding a default 'extra-spacing-height to key signature.

1/10
Keith confirms that this works and that he gets a clean make check.

1/13
Phil holmes reports the regression on the bugtracker (2.13.46).
Graham identifies that the output was correct on the bugtracker (2.12.3).

1/19
Mike confirms that the regression is indeed due to 1190 and realizes that  
he is not subscribed to the bug list.
Mike proposes a patch based on the discussion between Neil and Keith, on  
Rietveld @ http://codereview.appspot.com/4031042.
Make check passes.

1/19
Mike poses a second patch that conforms more to Neil's observation  
that: "Clefs are taken into account (shown by the yellow-blue skyline pair)  
when calculating horizontal skylines for NonMusicalPaperColumn, whereas key  
signatures are completely ignored.  We can ensure KeySignature is accounted  
for by adding it to `pure-print-callbacks'."  Patch up on  
http://codereview.appspot.com/4006044 .

CURRENT STATE :: The second patch seems to be the one towards which people  
who are responding are leaning.  Please review and comment.