bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1228 in lilypond: \override RestCollision #'positioning-done =


From: lilypond
Subject: Re: Issue 1228 in lilypond: \override RestCollision #'positioning-done = #merge-rests-on-positioning
Date: Mon, 24 Jan 2011 18:20:16 +0000


Comment #8 on issue 1228 by address@hidden: \override RestCollision #'positioning-done = #merge-rests-on-positioning
http://code.google.com/p/lilypond/issues/detail?id=1228

Here is a 'work-in-progress' patch based on the above thread as an initial attempt to put this in the main LP code base.

However 'as is' it will not yet compile (am getting unbound variable message) however I don't have the expertise to troubleshoot this probably trivial issue.

That said, Neil Puttock as said in the Rietveld Thread

--snip--

Neil Puttock    
This is a nice hack, but the way it's currently implemented makes it unsuitable to ...
        19 hours, 2 minutes ago

This is a nice hack, but the way it's currently implemented makes it unsuitable
to be merged.

The full-bar rests should be collected by an engraver (like the
Rest_collision_engraver), rather than using a hash table.

---snip---

Carl Sorensen followed up with:

Neil's comment indicated that this approach wrong for getting this
functionality into the LilyPond distribution.  He suggests that a new
engraver will be needed.

Therefore, putting this up as an LSR snippet in the original form is
probably the best thing to do right now, IMO.

Thanks,

Carl

---

I'll look at the existing snippet in the LSR and see if this one is better or add it as another one.

I don't know if the 'type' needs to be changed or not for this tracker item

James



Attachments:
        0001-Add-new-merge-function.ly-file-for-rests.patch  6.6 KB




reply via email to

[Prev in Thread] Current Thread [Next in Thread]